{{link-to}} with model and query params and target route with refreshModel: true errors

[wagenet]

https://ember-twiddle.com/c7cd718c4960e8a5d6b3abe3f2de5fd3 (Click link and see console)

[wagenet]

A possible fix is to check in queryParamsDidChange that the route is actually active. AFAICT the problem happens because it fires (unncessarily?) before the route is actually entered.

[raytiley]

This seems the same as an issue I'm trying to trackdown:

https://ember-twiddle.com/0c7e72433e1a3149a7304007fbbd1a54

The issue, as best I can explain it, is that queryParams only transitions have a special short circuit in router.js that fires the queryParamsDidChange https://github.com/tildeio/router.js/blob/master/lib/router/router.js#L38-L43

This code can get hit before the contexts for a route are setup yet, so there is not controller to set the query params on. There must be some code path, maybe setupContexts that gets fired in a normal transition after that short circuit for the queryParams only transition. I spent a few hours digging in the other night to get this far, hoping I can figure it out further over the weekend /CC @rwjblue (this is the crazy shit I wanted to pair w/ you a bit on)

[wagenet]

To be clear, the issue appears to not just be for queryParam only transitions. It also happens when you're transitioning to a new route with query params.

[mattmarcum]

This looks to be the same bug as this: #11563.

@raytiley I came to the same conclusion about the controller not being setup yet. Any chance your wip branch can be extended to cover this bug too? I have a branch with the failing tests here

[Serabe]

More reproductions of this issues can be found in #13954

[pixelhandler]

@mattmarcum @raytiley @wagenet is this still an issue, perhaps we should close or create a new reproduction of this, what do you think?

[pixelhandler]

Closing for now, feel free to re-open if you can reproduce in the current release of Ember.

• https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#triaging-policy