Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 2.8.0: RSVP.Promise.reject uncaught exception when provided arguments #14277

Closed
anssikin opened this issue Sep 13, 2016 · 6 comments
Closed
Milestone

Comments

@anssikin
Copy link

Fresh application with Ember-CLI 2.8.0, Node 6.3.1 and Ember 2.8.0 throws uncaught exception when Ember.RSVP.Promise.reject is called with one or more arguments. I did not find any mention of changed behavior in changelog, so I'm assuming this is a bug.

screen shot 2016-09-13 at 13 31 51

@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2016

Definitely seems bizarre. I do not think that 2.8.0 included an updated RSVP (but I believe 2.9 does), so it seems unlikely to be an RSVP bug.

Can you share the full stack from that error?

@rwjblue rwjblue added this to the 2.8.0 milestone Sep 13, 2016
@anssikin
Copy link
Author

Sure. Here is another screen capture.

screen shot 2016-09-13 at 14 41 05

The exception seems to come from ember-metal/error_handler module, a function calledgetStack. I'm using Chrome Version 52.0.2743.116 (64-bit) on OSX, if that helps.

@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2016

Perfect, thank you!

@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2016

This was fixed by #14184 and pulled into beta, but I didn't realize it also needed to be fixed in release. I'll get it pulled down and prepared for the next patch release.

@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2016

OK, updated now, in a few minutes you can use the release channel to get a working build but I believe we will have 2.8.1 out in a couple days.

@rwjblue rwjblue closed this as completed Sep 13, 2016
@anssikin
Copy link
Author

Great. Thanks for the super quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants