Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache FactoryManager instances #15007

Closed
stefanpenner opened this issue Mar 14, 2017 · 0 comments · Fixed by #15009
Closed

cache FactoryManager instances #15007

stefanpenner opened this issue Mar 14, 2017 · 0 comments · Fixed by #15009

Comments

@stefanpenner
Copy link
Member

FactoryManager should likely be cached, as it seems strange to create new ones for each instance.

In addition, we could cache the result of makeToString on it, so we don't need to create so many of those either.

cc @chadhietala
@stefanpenner stefanpenner changed the title cache FactoryManager cache FactoryManager instances Mar 14, 2017
@stefanpenner stefanpenner mentioned this issue Mar 14, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX beta] [PERF] Cache FactoryManagers emberjs/ember.js
1 participant
@stefanpenner