Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression Canary] Ember.EXTEND_PROTOTYPES is undefined #16511

Closed
mixonic opened this issue Apr 12, 2018 · 0 comments
Closed

[regression Canary] Ember.EXTEND_PROTOTYPES is undefined #16511

mixonic opened this issue Apr 12, 2018 · 0 comments

Comments

@mixonic
Copy link
Member

mixonic commented Apr 12, 2018

In #16467 Ember.EXTEND_PROTOTYPES was removed from the framework. Common libraries like ember-inflector use this value (source) and we need to have an intimate API deprecation cycle here.

For example:

Object.defineProperty(Ember, 'EXTEND_PROTOTYPES', {
  enumerable: false,
  get() {
    deprecate('Accessing Ember.EXTEND_PROTOTYPES is deprecated, please migrate to Ember.ENV.EXTEND_PROTOTYPES');
    return ENV.EXTEND_PROTOTYPES;
  }
});

(where the value used to be set: source)

/cc @rwjblue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant