Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for RFC #435 (forwarding modifiers via splattributes) #17493

Closed
chancancode opened this issue Jan 18, 2019 · 4 comments
Closed

Tracking Issue for RFC #435 (forwarding modifiers via splattributes) #17493

chancancode opened this issue Jan 18, 2019 · 4 comments
Labels
Bug

Comments

@chancancode
Copy link
Member

chancancode commented Jan 18, 2019 •
edited by wycats
Loading

https://github.com/emberjs/rfcs/blob/master/text/0435-modifier-splattributes.md
@chancancode chancancode mentioned this issue Jan 18, 2019
Closed
@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2019

Yes, IMHO this is just a bug that we should fix.

@rwjblue rwjblue added the Bug label Jan 18, 2019
@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2019

Specifically, I believe that we need to remove this:

https://github.com/glimmerjs/glimmer-vm/blob/11033eb39331e42068b9e7f35c19764ceb1f5737/packages/%40glimmer/compiler/lib/javascript-compiler.ts#L269-L271

And add some tests in glimmer-vm for this case.

@chancancode
Copy link
Member Author

emberjs/rfcs#435

@wycats wycats changed the title Compile Error: Element modifiers are not allowed in components Tracking Issue for RFC #435 Jan 28, 2019
@wycats wycats changed the title Tracking Issue for RFC #435 Tracking Issue for RFC #435 (forwarding modifiers via splattributes) Jan 28, 2019
@kategengler kategengler mentioned this issue Apr 19, 2019
Closed
6 tasks
@rwjblue
Copy link
Member

rwjblue commented Apr 24, 2019

This is done, and enabled by default in #17901

@rwjblue rwjblue closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @chancancode