Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Octane] Ember Data model @attr doesn't track #18253

Closed
wongpeiyi opened this issue Aug 11, 2019 · 2 comments
Closed

[Octane] Ember Data model @attr doesn't track #18253

wongpeiyi opened this issue Aug 11, 2019 · 2 comments

Comments

@wongpeiyi
Copy link

I'm not sure if this is more an Ember Data issue or an unimplemented feature etc

I have a getter that computes off a DS @attr. When the attr changes, the template updates correctly once, but if it changes again subsequently the template doesn't update.

Switching from @attr to @tracked works perfectly however, and so does displaying the attr directly in the template. The only failing case is a getter based off an attr.

Repro here: wongpeiyi/octane-test@6d8b8f1

@pzuraq
Copy link
Contributor

pzuraq commented Aug 11, 2019

I've confirmed that this is an issue with CPs in general, not just @attr (which is implemented as a CP under the hood). I've also confirmed that the work done in #18223 fixes this issue, so I'll add a test to that PR to ensure we cover it.

@wongpeiyi
Copy link
Author

Thanks @pzuraq, looks like it's fixed in master after the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants