Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 3.25.0-beta.3: curly component names are normalized differently #19360

Closed
dfreeman opened this issue Jan 27, 2021 · 1 comment
Closed

Comments

@dfreeman
Copy link
Contributor

🐞 Describe the Bug

In [email protected] and prior, a component invoked in block form like {{#pkg::component-name}} would be looked up via the resolver as pkg::component-name.

Starting with beta.3 with the upgrade to [email protected], that name is normalized via customizeComponentName to become pkg/component-name. For a customized resolver where :: is a meaningful token, such components no longer resolve correctly.

🔬 Minimal Reproduction

The following is resolved as component:pkg::component-name in beta.2, but component:pkg/component-name in beta.3:

{{#pkg::component-name}}
  hello!
{{/pkg::component-name}}

Note that an inline invocation like {{pkg::component-name}} does not go through customizeComponentName and so still resolves as before.

😕 Actual Behavior

Block curly component names have :: normalized to /.

🤔 Expected Behavior

Block curly component names aren't subjected to the same normalization rules as angle-bracket components, as in prior releases.

🌍 Environment

  • Ember: 3.25.0-beta.3

➕ Additional Context

Additional discussion of the details of this issue is at glimmerjs/glimmer-vm#1255

@rwjblue
Copy link
Member

rwjblue commented Feb 1, 2021

Fixed by #19363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants