Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EMBER_TYPESCRIPT_BLUEPRINTS feature #20177

Closed
Tracked by #873
bertdeblock opened this issue Aug 31, 2022 · 4 comments · Fixed by #20352
Closed
Tracked by #873

Enable EMBER_TYPESCRIPT_BLUEPRINTS feature #20177

bertdeblock opened this issue Aug 31, 2022 · 4 comments · Fixed by #20352
Labels
TypeScript Work on Ember’s types

Comments

@bertdeblock
Copy link
Member

Currently, this feature is turned off and users need to explicitly run EMBER_TYPESCRIPT_BLUEPRINTS=true ember g ... to generate TS files. This can be confusing when people also set "isTypeScriptProject": true in their .ember-cli file.
This issue serves as a reminder to enable this feature or to determine what's needed to enable it.

/cc @chriskrycho

@chriskrycho
Copy link
Contributor

@bertdeblock is this still the case? I don't remember where this landed!

@bertdeblock
Copy link
Member Author

bertdeblock commented Nov 19, 2022

@chriskrycho Yup, to enable TS blueprints by default (based on the isTypeScriptProject value of course) we need to enable this flag.

@chriskrycho
Copy link
Contributor

Thanks for clarifying. Do you happen to know if that's the only thing we're blocked on (you've been way more closely involved in the implementation than I have 🙏🏼😅)? If so, I'll bring it up at the next Framework meeting as well as discuss it async with the Typed Ember team and we can see about a path to turning on that flag!

@bertdeblock
Copy link
Member Author

AFAIK, that's the only remaining thing to do, to have TS blueprints just work indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants