Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port applyClassNameBindings to use attr nodes #9922

Closed
mixonic opened this issue Dec 15, 2014 · 4 comments
Closed

Port applyClassNameBindings to use attr nodes #9922

mixonic opened this issue Dec 15, 2014 · 4 comments

Comments

@mixonic
Copy link
Member

mixonic commented Dec 15, 2014

applyClassNameBindings is slow. It should be ported to use streams and an attr node. Related to #9921, but class name bindings are their own weird world. The class name bindings code in general should be consolidated- the same steps are repeated in the each/collection helper, in bind-attr, and in applyClassNameBindings.

The bind-attr implementation has been ported already.

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2015

@mixonic - I believe that this is something you are working on currently, c/d?

@mixonic
Copy link
Member Author

mixonic commented Jan 5, 2015

Focusing on attr bindings re: #9921, but after that this will be a piece of cake.

@rwjblue
Copy link
Member

rwjblue commented Feb 7, 2015

attributeBindings landed in #10186. I believe that this is next on the chopping block.

@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2015

Closing this, as I believe that AttrNode's are gone in Glimmer world.

@rwjblue rwjblue closed this as completed Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants