Skip to content

Latest commit

 

History

History
79 lines (63 loc) · 2.65 KB

0631-refresh-method-for-router-service.md

File metadata and controls

79 lines (63 loc) · 2.65 KB
stage start-date release-date release-versions teams prs project-link
recommended
2020-05-23 00:00:00 UTC
2021-12-28 00:00:00 UTC
ember-source
v4.1.0
framework
accepted recommended

RouterService#refresh

Summary

Add a refresh method to the router service that calls refresh on all currently active routes, or refreshes the descendents of the active route referred to by the pivot route name provided as an argument.

Motivation

We want to be able to call refresh on all currently active routes, or a subset of them, from a centralized service or from a component. As a side benefit, we will be able to do this without relying on the send api, which is being discussed as a possible deprecation in RFC 632. This enables us to get the latest data from the model hook.

Detailed design

The following pseudocode represents the overall technical design of this method. This code implementation is not normative.

class RouterService {
    refresh(pivotRouteName?: string): Transition {
        let pivotRoute = pivotRouteName && lookupRoute(pivotRouteName);
        assert("If an argument provided must be the name of an active route", !pivotRouteName || isActiveRoute(pivotRoute));
        return this._router._routerMicroLib.refresh(pivotRoute);
    }
}

where lookupRoute gets the route specified by the pivotRouteName, and isActiveRoute determines if the specified route is active. The method optionally takes the route name that will, along with its descendents, be refreshed. The method will return a promise that resolves when the refresh is complete.

How we teach this

The following documentation will be added to the method:

/**
 * Refreshes all currently active routes, doing a full transition.
 * If a pivotRouteName is provided and refers to a currently active route,
 * it will refresh only that route and its descendents.
 * Returns a promise that will be resolved once the refresh is complete.
 * All resetController, beforeModel, model, afterModel, redirect, and setupController
 * hooks will be called again. You will get new data from the model hook.
 *
 * @method refresh
 * @param {String} [pivotRouteName] the route to refresh (along with all child routes)
 * @return Transition
 * @public
 */

Drawbacks

This is a slight increase in API surface area.

Alternatives

We could provide a direct link to the current route via the router service. However, this would encourage people to use routes to store information and provide methods that should be idiomatically placed in a service.