From 47dbda3a5b23d7ef3e858b77d182f25bd48c4f9d Mon Sep 17 00:00:00 2001 From: wagenet Date: Wed, 23 Nov 2022 17:11:29 +0000 Subject: [PATCH 1/3] Advance RFC to Stage recommended --- text/0756-helper-default-manager.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/text/0756-helper-default-manager.md b/text/0756-helper-default-manager.md index 005410f1f6..fe6dda6737 100644 --- a/text/0756-helper-default-manager.md +++ b/text/0756-helper-default-manager.md @@ -1,15 +1,14 @@ --- -stage: released # FIXME: This may be recommended +stage: recommended start-date: 2021-05-17T00:00:00.000Z release-date: 2022-05-13T00:00:00.000Z release-versions: ember-source: v4.5.0 - teams: - framework - learning prs: - accepted: https://github.com/emberjs/rfcs/pull/756 + accepted: 'https://github.com/emberjs/rfcs/pull/756' project-link: --- @@ -156,7 +155,7 @@ setHelperManager(() => DEFAULT_HELPER_MANAGER, Function.prototype); - when the "helper" is created, the function is not invoked - when `getValue` is invoked, - the function is invoked with the named arguments all grouped into the last arg - - if no named arguments are given, an empty object is used instead to allow less nullish checking in userland + - if no named arguments are given, an empty object is used instead to allow lessish checking in userland - to register this helper manager, it should occur during app boot so developers do not need to import anything to trigger the `setHelperManager` call From 42dd05a30639606222c4e2c2ff2774d29df08e88 Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Wed, 23 Nov 2022 17:11:33 +0000 Subject: [PATCH 2/3] Update RFC 0756 recommended PR URL --- text/0756-helper-default-manager.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/0756-helper-default-manager.md b/text/0756-helper-default-manager.md index fe6dda6737..1af73dbe98 100644 --- a/text/0756-helper-default-manager.md +++ b/text/0756-helper-default-manager.md @@ -9,6 +9,7 @@ teams: - learning prs: accepted: 'https://github.com/emberjs/rfcs/pull/756' + recommended: 'https://github.com/emberjs/rfcs/pull/866' project-link: --- From a7a1462d70e0f01d82700647c23c06c972fb17ac Mon Sep 17 00:00:00 2001 From: Edward Faulkner Date: Fri, 3 Feb 2023 14:12:47 -0500 Subject: [PATCH 3/3] Update 0756-helper-default-manager.md --- text/0756-helper-default-manager.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0756-helper-default-manager.md b/text/0756-helper-default-manager.md index 1af73dbe98..f60738c618 100644 --- a/text/0756-helper-default-manager.md +++ b/text/0756-helper-default-manager.md @@ -156,7 +156,7 @@ setHelperManager(() => DEFAULT_HELPER_MANAGER, Function.prototype); - when the "helper" is created, the function is not invoked - when `getValue` is invoked, - the function is invoked with the named arguments all grouped into the last arg - - if no named arguments are given, an empty object is used instead to allow lessish checking in userland + - if no named arguments are given, an empty object is used instead to allow less nullish checking in userland - to register this helper manager, it should occur during app boot so developers do not need to import anything to trigger the `setHelperManager` call