-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate "old class binding" syntax #665
Comments
The |
If curly components are already on their way out (not officially deprecated, but still), isn't it easier to spend effort elsewhere? (not against the idea in itself though) |
Curly invocations themselves (which can be used to invoke any component) are not necessarily on their way out, they just have different use cases. Curly invocations support passing positional arguments which makes them a better fit for "helper-like" or "control-flow-like" components (which can be implemented using classic components or a custom component manager). |
I believe this was done in #691? |
Looks like this was completed. If not, it should be part of #832 |
Basically deprecate and remove this file: https://github.com/emberjs/ember.js/blob/aeef923e9f5f7dde2bc43fcdddabc4a3b98769ec/packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.ts
TL;DR deprecate passing
classBindings
andclassNameBindings
as arguments when doing curly component invocations, i.e. instead of{{my-component classNameBindings="foo:bar:baz"}}
, write{{my-component class=(if this.foo "bar" "baz")}}
, or better yet,<MyComponent class={{if this.foo "bar" "baz"}} />
.Note that
classBindings
andclassNameBindings
already does not work on angle bracket invocations.The text was updated successfully, but these errors were encountered: