Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ajax for fetch #782

Closed
snewcomer opened this issue Jan 2, 2022 · 2 comments · Fixed by #790
Closed

Deprecate ajax for fetch #782

snewcomer opened this issue Jan 2, 2022 · 2 comments · Fixed by #790
Labels
T-ember-data RFCs that impact the ember-data library

Comments

@snewcomer
Copy link
Contributor

Right now, ember-data's adapters connote the use of jquery/ajax through public-ish methods.

See minimum-adapter-interface for the proper public API of ember-data's adapters. Note there is no mention of ajax, but there are many methods that users tend to override in their adapters.

With Ember 4.0 dropping jQuery, we should take a hard stance on dropping the use of Ajax in the next major release. Currently in 4.0, ember-data does suggest the use of fetch in their adapters but can be overridden by setting useFetch = false.

In managing our transition to fetch based methods, we can do some light maintenance work to expose fetch related methods and drop switching between fetch and ajax with useFetch. The goal here would be to help improve user's understanding and use of our adapters. Moreover, this refactor may help us take a very small step to a world where we completely rethink the idea of adapters/serializers.

https://github.com/ember-cli/ember-fetch

@snewcomer snewcomer added the T-ember-data RFCs that impact the ember-data library label Jan 2, 2022
@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

Can we just make the RFC for this?

@runspired
Copy link
Contributor

@wagenet there is #790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-ember-data RFCs that impact the ember-data library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants