Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate addon sizes #33

Open
kategengler opened this issue Jul 12, 2018 · 7 comments
Open

Calculate addon sizes #33

kategengler opened this issue Jul 12, 2018 · 7 comments

Comments

@kategengler
Copy link
Member

No description provided.

@mansona
Copy link
Contributor

mansona commented Apr 24, 2019

Hey @kategengler 👋

I was curious about this issue because I think I've heard you talk about this before 🤔 is this the one where you were saying that you would need to have a base ember app and install the addon to and check the difference in asset sizes to be able to gather this data?

I'd be interested in helping out with this if it's something that would help you and has a "place" for it to go. Is there an example of an existing batch job that I could take a look at?

@kategengler
Copy link
Member Author

Hi @mansona, yes I've definitely spoken about this before and that is roughly the process but fortunately @lonelyghost is actively working on it.

@mansona
Copy link
Contributor

mansona commented Apr 24, 2019

oh that's amazing news 🎉 thanks for letting me know @kategengler 👍

@mansona
Copy link
Contributor

mansona commented May 28, 2021

Hey 👋 I had someone ask me today about asset size effects of addons and I wondered if there was any more progress on this?

I'm still interested in helping out if it would indeed be helpful 😄

@kategengler
Copy link
Member Author

Hi @mansona -- it might be a bit hard to notice, but we did this! The sizes are shown under dependencies on an addon for the ones we have data. @lonelyghost is going to make the addon's own size available on each addon's page (right now it is only visible on the dependency list from other addons).

One thing we could use help with is figuring out what this calculation looks like in an embroider world. Right now we use a new ember app, make a prod build, record asset sizes, add the addon, build a prod build, record the asset sizes and subtract.

@mansona
Copy link
Contributor

mansona commented Jun 1, 2021

Ha wow! That's pretty awesome 🎉 I would never have thought to look for it where you said 😂

As for the embroider world, I would imagine this will solve itself eventually no? Seeing as we're eventually going to have embroider as the default experience for new apps, whenever that happens your tooling that generates a new app and installs the addon will actually be generating an app with Embroider.

I guess we could show the comparison before then but that sounds complex 🙈

@kategengler
Copy link
Member Author

Embroider (and ember-auto-import v2) don't generate only App JS, Vendor JS, App CSS, etc (see https://github.com/ef4/ember-auto-import/blob/master/docs/upgrade-guide-2.0.md#inject-entry-chunks-directly-in-indexhtml), So, once ember-auto-import v2 is in the default new app, our modeling of the asset sizes will no longer be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants