Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slashes and .git from repo URLs at fetch time #36

Open
pgengler opened this issue Jul 14, 2018 · 1 comment
Open

Remove trailing slashes and .git from repo URLs at fetch time #36

pgengler opened this issue Jul 14, 2018 · 1 comment

Comments

@pgengler
Copy link
Collaborator

When fetching addon data, repo URLs should have trailing slashes and trailing .git stripped before they're saved to the DB. This will eliminate the need to do this on the client side (like in emberobserver/client#115) and will generally look better in the UI.

@pgengler
Copy link
Collaborator Author

This should also the point for any other repo URL normalization. For example, replacing git:// urls (as with https://emberobserver.com/addons/ember-material-addon) with https:// ones as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant