Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript #10

Closed
simonihmig opened this issue May 13, 2022 · 3 comments
Closed

Support TypeScript #10

simonihmig opened this issue May 13, 2022 · 3 comments

Comments

@simonihmig
Copy link
Collaborator

When RFC800 has landed, especially the --typescript flag for ember addon (see https://emberjs.github.io/rfcs/0800-ts-adoption-plan.html#cli-integration), we should support that here as well. Especially as we need to compile TypeScript in rollup, so support in addons is not as trivial as for v1 addons (ember install ember-cli-typescript).

Some prior art:

@simonihmig
Copy link
Collaborator Author

There has been some discussion about problems transpiling decorators:

We might want to only let Babel transpile code, including decorators, and let tsc only emit types. Like in https://github.com/evoactivity/ember-fast-marquee/pull/1/files

@NullVoxPopuli
Copy link
Collaborator

all problems that I'm aware are resolved atm.

the last thing is getting strict about extensions in the rollup plugin configs

@simonihmig
Copy link
Collaborator Author

For the record, we don't actually need to wait for official --typescript support in ember addon, as it turned out we can support additional flags even when the base command does not declare them.

So I would suggest we add this asap here once all remaining questions on embroider-build/embroider#1099 are resolved and the PR is merged. This can then serve as the "blueprint" (pun intended) for the implementation here...

@simonihmig simonihmig mentioned this issue Jul 6, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants