Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not ensure addon is built before running tests #224

Open
RobbieTheWagner opened this issue Nov 2, 2023 · 1 comment
Open

Does not ensure addon is built before running tests #224

RobbieTheWagner opened this issue Nov 2, 2023 · 1 comment

Comments

@RobbieTheWagner
Copy link

Per my discussion with @NullVoxPopuli we are relying on prepare to build the addon, but you might not have that script setup. It could be nice to tie the build into the test scripts.

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Nov 2, 2023

Thanks for reporting! this is def an area we can and should improve on!

tho, prepare will only run after install, so it wouldn't be good DX for post-install workflows.

I think we probably need to set up https://turbo.build/repo or https://github.com/google/wireit some similar tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants