Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup plugin that verifies and fixes the package.json (or other files) #1212

Closed
NullVoxPopuli opened this issue May 28, 2022 · 2 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented May 28, 2022

¿porque?

A number of issues that are really hard to debug come from misconfigured package.jsons

This could be done via lints, which we can discuss, I suppose.
I was kinda thinking that since we have a rollup plugin that already alters the package.json, maybe we add another one that does stuff like:

  • ensures data/structures exist:
    • type is unspecified
    • keywords has "ember-addon"
      • ember-addon has:
      • version: 2
      • type: addon
    • files has at least
      • output folder
    • if exports is specified,
      • all paths exist (imports, types, etc)
    • repository is correct (url, path, etc)
@ef4
Copy link
Contributor

ef4 commented Jun 2, 2022

Yes, it would be good to implement this via eslint. Along with any v2-addon-specific rules, we probably want to add some of the standard eslint-plugin-ember rules to the blueprint too.

@ef4
Copy link
Contributor

ef4 commented Jun 27, 2023

Superseded.

@ef4 ef4 closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants