You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest version of filesize does support the named import, so I think updating to that should fix this problem. Manually updating the code in node_modules so it uses the default export fixed the issue locally. Forcing it to the latest version with overrides also worked.
I can create a PR but guidance would be appreciated if tests are needed.
The text was updated successfully, but these errors were encountered:
I'm following the analyze.md guide and when I try the
EMBROIDER_CONCAT_STATS=true npm run build
command the build fails with the following error:(0 , filesize_1.filesize) is not a function
Looking at the stack trace and related code, it points to this line:
embroider/packages/core/src/measure-concat.ts
Line 22 in be02b4a
Or the compiled version:
It seems that v5 of the
filesize
package only has a default export but since it's imported as a named import in the code it fails.This is the commit that introduced that change: 1d350d9#diff-cfbd9511262fbeca1aa6e2e563f54f6852e46b3ba0db0d1381d693d11fdca2a8L4
The latest version of filesize does support the named import, so I think updating to that should fix this problem. Manually updating the code in node_modules so it uses the default export fixed the issue locally. Forcing it to the latest version with overrides also worked.
I can create a PR but guidance would be appreciated if tests are needed.
The text was updated successfully, but these errors were encountered: