Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes to bitcoin crate may break hdpath #2

Open
adizere opened this issue Jan 15, 2021 · 1 comment
Open

Recent changes to bitcoin crate may break hdpath #2

adizere opened this issue Jan 15, 2021 · 1 comment

Comments

@adizere
Copy link

adizere commented Jan 15, 2021

In our crate ibc-rs/relayer we're using hdpath for this particular with-bitcoin functionality.

We depend on hdpath as follows:

hdpath = { version = "0.6.0", features = ["with-bitcoin"] }

We also depend on the bitcoin crate:

bitcoin = { version = "0.25" }

Currently, hdpath has the following dep configuration towards bitcoin crate:

bitcoin = { version = ">= 0.21", optional = true }

Given this dependency configuration, cargo builds a dependency graph that looks as follows:

...
relayer v0.0.6 (/Users/adi/Hammers/ibc-rs/relayer)
├── anomaly v0.2.0 (*)
├── async-trait v0.1.42 (proc-macro) (*)
├── bech32 v0.7.2
├── bitcoin v0.25.2     <-------
├── hdpath v0.6.0
│   ├── bitcoin v0.26.0 <-------...

Notice the two versions of bitcoin (one is for 0.25, a direct dep for crate relayer, and another is at 0.26, a dep from hdpath). It is unclear why, but this leads to compilation issues, because the trait bound DerivationPath: From<StandardHDPath> could no longer be resolved.
The problem appeared recently, probably linked with the recent release of bitcoin v0.26.0; these changes may be relevant.

We solved this problem by depending on the latest version of bitcoin crate:

- bitcoin = { version = "0.25" }
+ bitcoin = { version = "=0.26" }

But we're not sure why the problem appeared in the first place.
Just wanted to flag this issue here, as other users of hdpath may run into this issue.

@splix
Copy link
Member

splix commented Jan 19, 2021

Hi @adizere! Thank you for bringing it in. I actually saw that with my another dependent project, but thought it's some misconfiguration on another side and didn't pay much attention.

Since you have it too, it's definitely something with the hdpath and I'll take a look what's wrong with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants