Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Envoy retry policies #1127

Closed
manigandham opened this issue Jan 22, 2019 · 3 comments
Closed

Support Envoy retry policies #1127

manigandham opened this issue Jan 22, 2019 · 3 comments
Assignees
Milestone

Comments

@manigandham
Copy link
Contributor

manigandham commented Jan 22, 2019

Automatic retries are a core feature of Envoy but the latest v0.50x doesn't support envoy_override anymore and there are no appropriate settings in the Mapping config.

This should be part of the Mapping API. It can support a basic subset until envoy_override is supported again or match the Envoy API.

@caiobegotti
Copy link

As a side comment, what is the expectation about supporting something like envoy_override again after 0.50.x? I can't upgrade it myself due to that, that's how I landed on this ticket here :-(

@richarddli
Copy link
Contributor

The v2 YAML configuration that Envoy uses is quite a bit more complex than the v1 configuration we used to support.

So, it's on the list, but it will be quite different. In the meantime, though, the Ambassador code is much cleaner, so would welcome direct contributions to the code base to support more features! :)

@richarddli
Copy link
Contributor

Merged to master, will be released shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants