From 262212cde2d0d68821a9d0313e8cac029c2a6856 Mon Sep 17 00:00:00 2001 From: Sam Magura Date: Mon, 1 Nov 2021 11:40:20 -0400 Subject: [PATCH 1/2] Document extra installation step for M1 Mac --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 481c8c30e..1f01240a9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,10 @@ ## Installation +- (If using an M1 Mac) Install `vips` via Homebrew: `brew install vips`. + - This step will become unnecessary once Sharp starts publishing prebuilt + binaries for darwin-arm64v8. + [Reference](https://github.com/lovell/sharp/issues/2460#issuecomment-751491241) - Run `yarn` in the repository's root directory to install everything you need for development. - Run `yarn build` in the root directory to build the modules. From 2f47a64101ad5af209fb29d18942546952f74e99 Mon Sep 17 00:00:00 2001 From: Sam Magura Date: Mon, 1 Nov 2021 14:04:29 -0400 Subject: [PATCH 2/2] Correct the M1 Mac vips explanation --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1f01240a9..359c36a5f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,9 +6,9 @@ ## Installation - (If using an M1 Mac) Install `vips` via Homebrew: `brew install vips`. - - This step will become unnecessary once Sharp starts publishing prebuilt - binaries for darwin-arm64v8. - [Reference](https://github.com/lovell/sharp/issues/2460#issuecomment-751491241) + - This step can be removed from this document if we upgrade to the latest + version of Gatsby, which is compatible with sharp 0.28.0+ which does include + binaries for M1 Macs. - Run `yarn` in the repository's root directory to install everything you need for development. - Run `yarn build` in the root directory to build the modules.