From 8572935b999f4212e6e4ebd7094be1dfc1df13e8 Mon Sep 17 00:00:00 2001 From: Sven Reichel Date: Wed, 19 Jul 2023 17:23:25 +0200 Subject: [PATCH] Removed phpstan.dist.issues.neon (#3257) * Removed phpstan.dist.issues.neon * trying to trigger phpstan * Revert "trying to trigger phpstan" This reverts commit 0e26c560593d6d2ab513376445c71fce839abb69. * trying to trigger phpstan * some fixes * some fixes * some fixes * some fixes * Revert "trying to trigger phpstan" This reverts commit 6bd2cdf8aa423c5e1110eec0ba7cfc9752603384. --------- Co-authored-by: Fabrizio Balliano --- phpstan.dist.baseline.neon | 803 ++++++++++++++++++++++++++++++++++++- phpstan.dist.issues.neon | 7 - phpstan.dist.neon | 1 - 3 files changed, 801 insertions(+), 10 deletions(-) delete mode 100644 phpstan.dist.issues.neon diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 1acbbf15087..273ab9c8998 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -115,6 +115,36 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php + - + message: "#^Variable \\$d might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + + - + message: "#^Variable \\$localmaxlength might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + + - + message: "#^Variable \\$localmaxvalue might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + + - + message: "#^Variable \\$localminvalue might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php + + - + message: "#^Variable \\$class might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php + + - + message: "#^Variable \\$value might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php + - message: "#^Access to an undefined property Mage_Adminhtml_Block_Notification_Window\\:\\:\\$_aclResourcePath\\.$#" count: 1 @@ -260,6 +290,21 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + - + message: "#^Variable \\$createLabelUrl might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + + - + message: "#^Variable \\$itemsGridUrl might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + + - + message: "#^Variable \\$itemsOrderItemId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php + - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 @@ -305,11 +350,81 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Config/Edit.php + - + message: "#^Variable \\$attributes might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php + + - + message: "#^Variable \\$img might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php + + - + message: "#^Variable \\$liStyle might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php + - message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php + - + message: "#^Variable \\$addLabel might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + + - + message: "#^Variable \\$deleteLabel might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + + - + message: "#^Variable \\$deleteUrl might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + + - + message: "#^Variable \\$editLabel might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + + - + message: "#^Variable \\$saveLabel might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php + + - + message: "#^Variable \\$groupModel might not be defined\\.$#" + count: 18 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$showGroupFieldset might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$showStoreFieldset might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$showWebsiteFieldset might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$storeModel might not be defined\\.$#" + count: 21 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + + - + message: "#^Variable \\$websiteModel might not be defined\\.$#" + count: 15 + path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php + - message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" count: 1 @@ -400,6 +515,16 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + - + message: "#^Variable \\$billingAddress might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + + - + message: "#^Variable \\$shippingAddress might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php + - message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" count: 1 @@ -430,6 +555,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/System/Store.php + - + message: "#^Variable \\$values might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/Model/System/Store.php + - message: "#^Return type \\(Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute\\) of method Mage_Adminhtml_Catalog_Product_Action_AttributeController\\:\\:_getHelper\\(\\) should be compatible with return type \\(Mage_Adminhtml_Helper_Data\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getHelper\\(\\)$#" count: 1 @@ -530,6 +660,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + - + message: "#^Variable \\$pdf might not be defined\\.$#" + count: 4 + path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php + - message: "#^Variable \\$data in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -545,6 +680,31 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + - + message: "#^Variable \\$codeBase might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$itemId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$model might not be defined\\.$#" + count: 5 + path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$notExists might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + + - + message: "#^Variable \\$title might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php + - message: "#^Method Mage_Directory_Model_Country\\:\\:loadByCode\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -680,11 +840,21 @@ parameters: count: 4 path: app/code/core/Mage/Api2/Helper/Data.php + - + message: "#^Variable \\$adapters might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Api2/Helper/Data.php + - message: "#^Parameter \\#1 \\$roleId \\(int\\) of method Mage_Api2_Model_Acl\\:\\:addRole\\(\\) should be compatible with parameter \\$role \\(string\\|Zend_Acl_Role_Interface\\) of method Zend_Acl\\:\\:addRole\\(\\)$#" count: 1 path: app/code/core/Mage/Api2/Model/Acl.php + - + message: "#^Variable \\$operationName might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php + - message: "#^Method Mage_Api2_Model_Config\\:\\:getResourceGroup\\(\\) should return bool\\|Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\.$#" count: 1 @@ -825,6 +995,11 @@ parameters: count: 1 path: app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + - + message: "#^Variable \\$params might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php + - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" count: 1 @@ -870,6 +1045,11 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php + - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getIsPricesCalculatedByIndex\\(\\)\\.$#" count: 1 @@ -880,6 +1060,11 @@ parameters: count: 3 path: app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php + - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Interface\\:\\:getQty\\(\\)\\.$#" count: 1 @@ -955,6 +1140,21 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Product/Type.php + - + message: "#^Variable \\$basePrice might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$customOptions might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php + + - + message: "#^Variable \\$_items might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php + - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" count: 1 @@ -1025,6 +1225,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product.php + - + message: "#^Variable \\$productId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Product.php + - message: "#^Property Mage_Catalog_Block_Product_Abstract\\:\\:\\$_reviewsHelperBlock \\(Mage_Review_Block_Helper\\|null\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -1095,6 +1300,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + - + message: "#^Variable \\$finish might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + + - + message: "#^Variable \\$start might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php + - message: "#^Property Mage_Catalog_Block_Product_Widget_New\\:\\:\\$_pager \\(Mage_Catalog_Block_Product_Widget_Html_Pager\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -1110,6 +1325,21 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Product.php + - + message: "#^Variable \\$finish might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + + - + message: "#^Variable \\$start might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php + + - + message: "#^Variable \\$store might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Block/Widget/Link.php + - message: "#^Property Mage_Catalog_Helper_Data\\:\\:\\$_categoryPath \\(string\\) does not accept array\\\\>\\.$#" count: 1 @@ -1290,6 +1520,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Design.php + - + message: "#^Variable \\$_category might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Design.php + - message: "#^Property Mage_Catalog_Model_Entity_Product_Attribute_Design_Options_Container\\:\\:\\$_configNodePath \\(Mage_Core_Model_Config_Element\\) does not accept string\\.$#" count: 1 @@ -1515,21 +1750,51 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category.php + - + message: "#^Variable \\$condition might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php + - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + - + message: "#^Variable \\$options might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php + - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getMainStoreTable\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + - + message: "#^Variable \\$condition might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php + - message: "#^Call to an undefined method Zend_Db_Select\\:\\:insertFromSelect\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + - + message: "#^Variable \\$anchorProductsTable might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Variable \\$anchorTable might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + + - + message: "#^Variable \\$enabledTable might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php + - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" count: 2 @@ -1630,6 +1895,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + - + message: "#^Variable \\$websiteId might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php + - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:getCount\\(\\) should return int but returns string\\|false\\|null\\.$#" count: 1 @@ -1660,6 +1930,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php + - + message: "#^Variable \\$category might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Catalog/Model/Resource/Url.php + - message: "#^Loose comparison using \\=\\= between true and true will always evaluate to true\\.$#" count: 2 @@ -1675,6 +1950,16 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Attribute.php + - + message: "#^Variable \\$idField might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + + - + message: "#^Variable \\$whereField might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php + - message: "#^Parameter \\#1 \\$product \\(array\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with parameter \\$product \\(int\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" count: 1 @@ -1700,6 +1985,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer.php + - + message: "#^Variable \\$storeObject might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/CatalogIndex/Model/Indexer.php + - message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Eav\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" count: 1 @@ -1760,6 +2050,26 @@ parameters: count: 1 path: app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh/Row.php + - + message: "#^Variable \\$gId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$pId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$wId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogRule/Model/Observer.php + + - + message: "#^Variable \\$indexAlias might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogRule/Model/Resource/Rule/Product/Price.php + - message: "#^Call to an undefined method Mage_Rule_Model_Condition_Combine\\:\\:collectValidatedAttributes\\(\\)\\.$#" count: 1 @@ -1770,6 +2080,16 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php + - + message: "#^Variable \\$temp might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogSearch/Block/Term.php + + - + message: "#^Variable \\$termKeys might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/CatalogSearch/Block/Term.php + - message: "#^Property Mage_CatalogSearch_Helper_Data\\:\\:\\$_queryText \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 @@ -1780,6 +2100,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Model/Advanced.php + - + message: "#^Variable \\$select might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/CatalogSearch/Model/Resource/Advanced/Collection.php + - message: "#^If condition is always true\\.$#" count: 1 @@ -1840,6 +2165,11 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Coupon/Api.php + - + message: "#^Variable \\$customer might not be defined\\.$#" + count: 4 + path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php + - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" count: 1 @@ -1925,6 +2255,11 @@ parameters: count: 1 path: app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php + - + message: "#^Variable \\$query might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php + - message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -2000,6 +2335,26 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + - + message: "#^Variable \\$action might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$controller might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$controllerInstance might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + + - + message: "#^Variable \\$realModule might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php + - message: "#^Method Mage_Core_Helper_Abstract\\:\\:_getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" count: 1 @@ -2090,6 +2445,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Config.php + - + message: "#^Variable \\$key might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Core/Model/Config.php + - message: "#^Method Mage_Core_Model_Cookie\\:\\:getHttponly\\(\\) should return bool but returns null\\.$#" count: 1 @@ -2165,6 +2525,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/File/Storage.php + - + message: "#^Variable \\$parentId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php + - message: "#^PHPDoc tag @param for parameter \\$filter with type array\\|Zend_Filter_Interface is not subtype of native type Zend_Filter_Interface\\.$#" count: 1 @@ -2255,6 +2620,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + - + message: "#^Variable \\$alias might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php + - message: "#^Variable \\$columnsToSelect in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -2365,6 +2735,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite.php + - + message: "#^Variable \\$targetUrl might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Core/Model/Url/Rewrite.php + - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -2386,9 +2761,14 @@ parameters: path: app/code/core/Mage/Core/functions.php - - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" + message: "#^Variable \\$arguments might not be defined\\.$#" count: 1 - path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php + path: app/code/core/Mage/Cron/Model/Observer.php + + - + message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" + count: 1 + path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_websiteId \\(string\\|null\\) does not accept int\\|null\\.$#" @@ -2475,6 +2855,11 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + - + message: "#^Variable \\$regionId might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php + - message: "#^Method Mage_Directory_Model_Region\\:\\:loadByName\\(\\) invoked with 1 parameter, 2 required\\.$#" count: 1 @@ -2615,6 +3000,16 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Profile.php + - + message: "#^Variable \\$parseFileXml might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Dataflow/Model/Profile.php + + - + message: "#^Variable \\$path might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Dataflow/Model/Profile.php + - message: "#^Method Mage_Directory_Helper_Data\\:\\:getCountryCollection\\(\\) should return Mage_Directory_Model_Resource_Country_Collection but returns Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 @@ -2630,11 +3025,21 @@ parameters: count: 1 path: app/code/core/Mage/Directory/Model/Country.php + - + message: "#^Variable \\$response might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Directory/Model/Currency/Import/Fixerio.php + - message: "#^Method Mage_Directory_Model_Currency_Import_Webservicex\\:\\:_convert\\(\\) should return float\\|null but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Directory/Model/Currency/Import/Webservicex.php + - + message: "#^Variable \\$importModel might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Directory/Model/Observer.php + - message: "#^Left side of && is always true\\.$#" count: 1 @@ -2650,6 +3055,11 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Helper/Download.php + - + message: "#^Variable \\$downloadableModel might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Downloadable/Model/Link/Api.php + - message: "#^Parameter \\#2 \\$resource \\(object\\) of method Mage_Downloadable_Model_Link_Api_V2\\:\\:add\\(\\) should be compatible with parameter \\$resource \\(array\\) of method Mage_Downloadable_Model_Link_Api\\:\\:add\\(\\)$#" count: 1 @@ -2715,6 +3125,16 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + - + message: "#^Variable \\$defBind might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + + - + message: "#^Variable \\$entityIds might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php + - message: "#^Binary operation \"\\.\" between Mage_Eav_Model_Entity_Interface and '_collection' results in an error\\.$#" count: 1 @@ -2730,6 +3150,16 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + - + message: "#^Variable \\$collection might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + + - + message: "#^Variable \\$entity might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getReadAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -2765,6 +3195,31 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + - + message: "#^Variable \\$attributeCode might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$id might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$instance might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$method might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + + - + message: "#^Variable \\$part might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Abstract.php + - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdByCode\\(\\)\\.$#" count: 1 @@ -2830,6 +3285,31 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + - + message: "#^Variable \\$attrArr might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$bindAttribute might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$entity might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$query might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + + - + message: "#^Variable \\$select might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php + - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -2860,6 +3340,11 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Setup.php + - + message: "#^Variable \\$connection might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Entity/Setup.php + - message: "#^Property Mage_Eav_Model_Entity_Type\\:\\:\\$_sets \\(Mage_Eav_Model_Resource_Entity_Attribute_Set_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -2890,6 +3375,11 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Set.php + - + message: "#^Variable \\$store might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Eav/Model/Resource/Form/Attribute/Collection.php + - message: "#^PHPDoc tag @param for parameter \\$object with type Mage_Eav_Model_Resource_Form_Type is incompatible with native type Mage_Core_Model_Abstract\\.$#" count: 2 @@ -3020,6 +3510,11 @@ parameters: count: 2 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + - + message: "#^Variable \\$collection might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php + - message: "#^Binary operation \"\\+\" between string and 50\\|int\\<100, max\\> results in an error\\.$#" count: 1 @@ -3070,6 +3565,11 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + - + message: "#^Variable \\$entityId might not be defined\\.$#" + count: 4 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" count: 1 @@ -3145,6 +3645,36 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + - + message: "#^Variable \\$prevOptionId might not be defined\\.$#" + count: 4 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$rowSku might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$sku might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php + + - + message: "#^Variable \\$productId might not be defined\\.$#" + count: 4 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + + - + message: "#^Variable \\$productSuperAttrId might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php + + - + message: "#^Variable \\$productData might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php + - message: "#^Method Mage_Index_Model_Lock\\:\\:getInstance\\(\\) should return \\$this\\(Mage_Index_Model_Lock\\) but returns Mage_Index_Model_Lock\\.$#" count: 1 @@ -3275,6 +3805,11 @@ parameters: count: 2 path: app/code/core/Mage/Log/Model/Resource/Log.php + - + message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" + count: 1 + path: app/code/core/Mage/Newsletter/Model/Subscriber.php + - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:isPartialAuthorization\\(\\)\\.$#" count: 1 @@ -3285,6 +3820,16 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/Model/Authorizenet.php + - + message: "#^Variable \\$defaultExceptionMessage might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Paygate/Model/Authorizenet.php + + - + message: "#^Variable \\$newTransactionType might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Paygate/Model/Authorizenet.php + - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" count: 1 @@ -3370,6 +3915,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Payflow/Link/Info.php + - + message: "#^Variable \\$isAjax might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php + - message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_export\\(\\)\\.$#" count: 1 @@ -3445,6 +3995,11 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express/Checkout.php + - + message: "#^Variable \\$shippingAddress might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Paypal/Model/Express/Checkout.php + - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:getAllowedCcTypes\\(\\) should be compatible with return type \\(string\\) of method Mage_Paypal_Model_Direct\\:\\:getAllowedCcTypes\\(\\)$#" count: 1 @@ -3550,6 +4105,16 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Block/Product/Abstract.php + - + message: "#^Variable \\$dateStart might not be defined\\.$#" + count: 7 + path: app/code/core/Mage/Reports/Helper/Data.php + + - + message: "#^Variable \\$t might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Reports/Helper/Data.php + - message: "#^Property Mage_Reports_Model_Grouped_Collection\\:\\:\\$_resourceCollection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 @@ -3595,6 +4160,11 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Order/Collection.php + - + message: "#^Variable \\$productViewEvent might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Reports/Model/Resource/Product/Collection.php + - message: "#^Property Mage_Reports_Model_Resource_Report_Collection\\:\\:\\$_from \\(string\\) does not accept int\\.$#" count: 1 @@ -3785,6 +4355,16 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Tax.php + - + message: "#^Variable \\$oldArea might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Order/Api.php + + - + message: "#^Variable \\$oldStore might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Order/Api.php + - message: "#^Property Mage_Sales_Model_Order_Creditmemo\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -3835,11 +4415,31 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + - + message: "#^Variable \\$order might not be defined\\.$#" + count: 12 + path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + + - + message: "#^Variable \\$shipment might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php + + - + message: "#^Variable \\$creditmemo might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php + - message: "#^Method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) should return string but returns array\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Pdf/Items/Abstract.php + - + message: "#^Variable \\$shipment might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php + - message: "#^Property Mage_Sales_Model_Order_Shipment\\:\\:\\$_items \\(Mage_Sales_Model_Resource_Order_Shipment_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -3905,6 +4505,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address.php + - + message: "#^Variable \\$totalInstance might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Sales/Model/Quote/Address.php + - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 @@ -4080,6 +4685,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/controllers/Billing/AgreementController.php + - + message: "#^Variable \\$billingAgreement might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Sales/controllers/Billing/AgreementController.php + - message: "#^Method Mage_Sales_Recurring_ProfileController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Recurring_ProfileController\\) but empty return statement found\\.$#" count: 1 @@ -4215,6 +4825,11 @@ parameters: count: 1 path: app/code/core/Mage/Tag/Block/Product/Result.php + - + message: "#^Variable \\$result might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tag/Model/Api.php + - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForAdd\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForAdd\\(\\)$#" count: 1 @@ -4235,6 +4850,16 @@ parameters: count: 1 path: app/code/core/Mage/Tag/Model/Entity/Customer/Collection.php + - + message: "#^Variable \\$productsSku might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tag/Model/Resource/Customer/Collection.php + + - + message: "#^Variable \\$result might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tag/Model/Tag.php + - message: "#^Call to an undefined method Mage_Tax_Block_Sales_Order_Tax\\:\\:addTotal\\(\\)\\.$#" count: 7 @@ -4290,6 +4915,21 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Config/Price/Include.php + - + message: "#^Variable \\$selectClone might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Tax/Model/Resource/Calculation.php + + - + message: "#^Variable \\$zipFrom might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Resource/Calculation.php + + - + message: "#^Variable \\$zipTo might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Resource/Calculation.php + - message: "#^Return type \\(array\\) of method Mage_Tax_Model_Sales_Total_Quote_Nominal_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\)$#" count: 1 @@ -4300,6 +4940,46 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + - + message: "#^Variable \\$baseRowTax might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$baseTax might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$baseTaxBeforeDiscountRounded might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$baseUnitTax might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$rowTax might not be defined\\.$#" + count: 3 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$tax might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$taxBeforeDiscountRounded might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + + - + message: "#^Variable \\$unitTax might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php + - message: "#^Property Mage_Shipping_Model_Carrier_Abstract\\:\\:\\$_code \\(string\\) on left side of \\?\\? is not nullable\\.$#" count: 1 @@ -4345,6 +5025,31 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + - + message: "#^Variable \\$shipKey might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + + - + message: "#^Variable \\$shippingLabelContent might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + + - + message: "#^Variable \\$specialServices might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + + - + message: "#^Variable \\$trackingNumber might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + + - + message: "#^Variable \\$xml might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php + - message: "#^Access to an undefined property Varien_Object\\:\\:\\$domestic\\.$#" count: 1 @@ -4405,6 +5110,16 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php + - + message: "#^Variable \\$package might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php + + - + message: "#^Variable \\$packageType might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php + - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl_Label_Pdf_Page\\:\\:drawText\\(\\) should return \\$this\\(Mage_Usa_Model_Shipping_Carrier_Dhl_Label_Pdf_Page\\) but returns Zend_Pdf_Canvas_Interface\\.$#" count: 1 @@ -4450,6 +5165,11 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php + - + message: "#^Variable \\$errorTitle might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php + - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Ups\\:\\:_getQuotes\\(\\) should return Mage_Shipping_Model_Rate_Result but returns null\\.$#" count: 1 @@ -4480,6 +5200,16 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php + - + message: "#^Variable \\$debugData might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php + + - + message: "#^Variable \\$response might not be defined\\.$#" + count: 2 + path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php + - message: "#^Access to an undefined property Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:\\$_rawTrackRequest\\.$#" count: 2 @@ -4560,11 +5290,26 @@ parameters: count: 2 path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Chooser.php + - + message: "#^Variable \\$options might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Form.php + + - + message: "#^Variable \\$productsOptions might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php + - message: "#^Cannot call method toOptionArray\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php + - + message: "#^Variable \\$template might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Widget/Model/Widget/Instance.php + - message: "#^Parameter \\#1 \\$item \\(Mage_Wishlist_Model_Item\\) of method Mage_Wishlist_Block_Share_Email_Items\\:\\:hasDescription\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Model_Product\\) of method Mage_Wishlist_Block_Abstract\\:\\:hasDescription\\(\\)$#" count: 1 @@ -4575,6 +5320,11 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Helper/Data.php + - + message: "#^Variable \\$params might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Wishlist/Helper/Data.php + - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -4585,6 +5335,11 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Model/Item/Option.php + - + message: "#^Variable \\$item might not be defined\\.$#" + count: 1 + path: app/code/core/Mage/Wishlist/Model/Wishlist.php + - message: "#^Method Mage_Wishlist_IndexController\\:\\:_addItemToWishList\\(\\) with return type void returns mixed but should not return anything\\.$#" count: 1 @@ -4595,6 +5350,11 @@ parameters: count: 3 path: app/code/core/Mage/Wishlist/controllers/IndexController.php + - + message: "#^Variable \\$cronMode might not be defined\\.$#" + count: 1 + path: cron.php + - message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\> and 0 is always true\\.$#" count: 1 @@ -4680,6 +5440,11 @@ parameters: count: 1 path: lib/Varien/Convert/Mapper/Column.php + - + message: "#^Variable \\$data might not be defined\\.$#" + count: 3 + path: lib/Varien/Convert/Parser/Xml/Excel.php + - message: "#^Cannot access property \\$_items on array\\.$#" count: 2 @@ -4735,11 +5500,21 @@ parameters: count: 1 path: lib/Varien/Data/Form/Element/Multiline.php + - + message: "#^Variable \\$node might not be defined\\.$#" + count: 1 + path: lib/Varien/Data/Tree.php + - message: "#^Method Varien_Data_Tree\\:\\:load\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 path: lib/Varien/Data/Tree/Node.php + - + message: "#^Variable \\$result might not be defined\\.$#" + count: 1 + path: lib/Varien/Db/Adapter/Mysqli.php + - message: "#^Cannot access offset 'Engine' on bool\\.$#" count: 1 @@ -4780,6 +5555,11 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Pdo/Mysql.php + - + message: "#^Variable \\$result might not be defined\\.$#" + count: 3 + path: lib/Varien/Db/Adapter/Pdo/Mysql.php + - message: "#^Cannot call method bindParam\\(\\) on object\\|resource\\.$#" count: 1 @@ -4854,3 +5634,22 @@ parameters: message: "#^Strict comparison using \\=\\=\\= between mixed and false will always evaluate to false\\.$#" count: 1 path: lib/Varien/Simplexml/Config.php + - + message: "#^Variable \\$aInfo might not be defined\\.$#" + count: 2 + path: lib/Varien/Db/Tree.php + + - + message: "#^Variable \\$pInfo might not be defined\\.$#" + count: 4 + path: lib/Varien/Db/Tree.php + + - + message: "#^Variable \\$sql might not be defined\\.$#" + count: 2 + path: lib/Varien/Db/Tree.php + + - + message: "#^Variable \\$methodName might not be defined\\.$#" + count: 2 + path: lib/Varien/Debug.php diff --git a/phpstan.dist.issues.neon b/phpstan.dist.issues.neon deleted file mode 100644 index 3c05c5a34c8..00000000000 --- a/phpstan.dist.issues.neon +++ /dev/null @@ -1,7 +0,0 @@ -parameters: - ignoreErrors: - # Level 2 - - "#Variable \\$+[a-zA-Z_]+ might not be defined.#" - - - message: "#Call to function is_null\\(\\) with bool will always evaluate to false.$#" - path: app/code/core/Mage/Newsletter/Model/Subscriber.php diff --git a/phpstan.dist.neon b/phpstan.dist.neon index eb99f86b075..76417afeff9 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -1,6 +1,5 @@ includes: - vendor/macopedia/phpstan-magento1/extension.neon - - phpstan.dist.issues.neon - phpstan.dist.baseline.neon - phar://phpstan.phar/conf/bleedingEdge.neon parameters: