Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON RPC2 interface #130

Open
6 tasks
DerAndereAndi opened this issue Oct 28, 2024 · 2 comments
Open
6 tasks

Implement JSON RPC2 interface #130

DerAndereAndi opened this issue Oct 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DerAndereAndi
Copy link
Member

DerAndereAndi commented Oct 28, 2024

The task is to coordinate development of JSON RPC2 implementation in #129

These items have been agreed upon:

  • Define Interface API
  • The EEBUS service should not start automatically, instead the option to start & stop should be used
  • Allow only one TCP connection at a time
  • Monitor active TCP connection and automatically call api.ServiceInterface.Shutdown() on disconnect
  • Add JSON parsing support for api.DeviceRemoteInterface and api.EntityRemoteInterface nested in structs (e. g. api.UseCaseBaseInterface.RemoteEntitiesScenarios()
  • ...

Please add your suggestions in comments and lets discuss them.

@DerAndereAndi DerAndereAndi added the enhancement New feature or request label Oct 28, 2024
@randomdudebunchofnumbers
Copy link

randomdudebunchofnumbers commented Oct 29, 2024

Some suggestions:

  • Remove service autostart
  • Allow only one TCP connection at a time
  • Monitor active TCP connection and automatically call api.ServiceInterface.Shutdown() on disconnect
  • Always return all return parameters
  • Add JSON parsing support for api.DeviceRemoteInterface and api.EntityRemoteInterface nested in structs (e. g. api.UseCaseBaseInterface.RemoteEntitiesScenarios()

@sthelen-enqs
Copy link
Contributor

I've created #131 to clean up the return parameters a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants