Double path unquote inside _TestClientTransport.__init__ method #2588
Unanswered
LowCostCustoms
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
An
unqote
function called at this piece of code https://github.com/encode/starlette/blob/master/starlette/testclient.py#L314, causes the request path to be unquoted twice: firstly by thehttpx.Request
class, and then by a manualunquote
function invocation over thehttpx.Request.path
property. This results in a discrepancy in the path processing rules between the mentioned and other transports, which could further lead to percent-encoded path parameters lost or corrupted in transition or worse: percent-encoding related bugs not caught by tests at all.Important
Beta Was this translation helpful? Give feedback.
All reactions