Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for URL datastructure, should call urlencode on password #662

Closed
taybin opened this issue Oct 8, 2019 · 1 comment
Closed

for URL datastructure, should call urlencode on password #662

taybin opened this issue Oct 8, 2019 · 1 comment

Comments

@taybin
Copy link

taybin commented Oct 8, 2019

Passwords can have special characters like @ and : which can break the URL format. This is probably true for the other fields of the URL as well.

@taybin
Copy link
Author

taybin commented Oct 8, 2019

Closing this in favor of issue in databases (encode/databases#145)

@taybin taybin closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant