Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack offset highlighting doesn't work for different instructions #32

Closed
LagoLunatic opened this issue Nov 22, 2023 · 1 comment
Closed

Comments

@LagoLunatic
Copy link

If you click on a particular stack offset, objdiff highlights other instances of that offset for similar instructions (e.g. stfs/lfs) as expected:
image

However, it misses instances that are for a completely different instruction (e.g. addi doesn't highlight lfs and lfs doesn't highlight addi):
image
image

Example function: dLib_checkActorInCircle
Versions tested on: 0.5.2, 0.6.0

@encounter
Copy link
Owner

Thanks for the report! I fixed this by comparing signed immediates and register offsets and considering them equivalent. If there are other instances where the highlight doesn't pick up things that it semantically should, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants