Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #1963

Open
captn3m0 opened this issue Dec 2, 2022 · 4 comments
Open

Improve accessibility #1963

captn3m0 opened this issue Dec 2, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@captn3m0
Copy link
Member

captn3m0 commented Dec 2, 2022

Is your feature request related to a problem? Please describe.
Product pages can be made more accessible.

Describe the solution you'd like
A clear review of accessibility issues, and fixes for the same. Most of this comes from the information we stuff in the table, but might apply elsewhere. This includes:

  1. Colors used in the table (See Accessibility Issues #1618, Improve contrast to meet WCAG #1620)
  2. Meaning of the colors
  3. Meaning of the strikethrough
  4. Dates perhaps? Since we use both relative and absolute dates, might want to make it more friendly.
  5. Meanings of Yes/No in support fields
  6. Better alt-text for releaseScheduleImages.

Adding ARIA annotations for some of the above will be helpful. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Annotations

@captn3m0 captn3m0 added the enhancement New feature or request label Dec 2, 2022
@hugovk
Copy link
Member

hugovk commented Dec 2, 2022

https://pagespeed.web.dev/ (also part of Lighthouse in Chrome devtools) and https://wave.webaim.org/ are useful accessibility tools.

For example, https://pagespeed.web.dev/report?url=https%3A%2F%2Fendoflife.date%2Fpython gives a score of 97 with 1 failed audit: "Links do not have a discernible name" and 10 to check manually.

And https://wave.webaim.org/report#/https://endoflife.date/python has 2 errors and 2 alerts.

@captn3m0
Copy link
Member Author

captn3m0 commented Dec 2, 2022

The automated checks are not that helpful, we need a better review - things like Color meanings for eg, or strikethrough meaning are entirely missed.

@marcwrobel marcwrobel changed the title Accessibility Improve accessibility Dec 2, 2022
@captn3m0
Copy link
Member Author

captn3m0 commented Jan 4, 2023

@mattxwang
Copy link

As an FYI, in the latest patch I just cut (0.5.2) I've added better accessibility roles/features for buttons. If there are other changes you want to upstream to JtD, would love to do so - accessibility is top-of-mind for me wrt the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants