Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding Bug #93

Open
Beyazatli opened this issue Feb 12, 2023 · 3 comments
Open

Padding Bug #93

Beyazatli opened this issue Feb 12, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Beyazatli
Copy link

Describe the bug
Hello,
There is a problem with the bottom item in the appearance of the drop-down menu.

Here are some devices where I encountered the view (space) error:
iPhone 11
Samsung (SM-A307FN/DS)
Samsung (SM-A920F)

I tried styling it but it had no effect.

To Reproduce
Steps to reproduce the behavior:

  1. Open hold menu.

Expected behavior
Just a little bit padding for last (actually bottom) item.

Screenshots (Two different devices)


Package versions

  • React: 18.1.0
  • React Native: 0.70.5
  • React Native Reanimated: ~2.12.0
  • React Native Hold Menu: ^0.1.5
  • Expo: ~47.0.12

Additional context
"Actions" section icon does not load (any icon - 'home', 'archive', etc.).

@Beyazatli Beyazatli added the bug Something isn't working label Feb 12, 2023
@Beyazatli
Copy link
Author

image

hi, when I updated the 37. line of the "style.ts" file from the node_modules folder, problem was solved. (temporarily 👾)

paddingVertical: styleGuide.spacing * 1.25,
to
paddingVertical: styleGuide.spacing * 1.1,

@Beyazatli
Copy link
Author

Hi,
previous solution doesnt work when i tested it on 10 different devices. rather than entering a different size for each screen format, the style.ts file needs to be rewritten with fixed dimensions.

@enesozturk
Copy link
Owner

Hey there, I saw the PR about the fix. I guess giving the flex is not a good solution since the sizes of the menu are really really important for the animations to run perfectly. We cannot let the menu calculate the size automatically.

So for the problem, this is not expected for sure, didn't see it before.

  • Do you only get this on the devices you listed? Not other devices?
  • What is the value of the font size in device settings?
  • Can you provide the code piece of the HoldMenu usage? (The list of items in your example.)
  • Can yo try without icons? (Thinking if they might be the reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants