Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Code Editor Embedding #168

Merged
merged 9 commits into from
Aug 29, 2020
Merged

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Aug 28, 2020

This fixes the code editor embedding into the timeline editor. Now the automatic slot connections work again. I used widget promotion with a QTextEdit as the dummy widget in the designer. When the form is instantiated the text edit gets promoted to the code editor.

  • Removed all that hacky shit in the constructor to frankenstein the widget.
  • Removed the _codeEditor member from the class.
  • Replaced the _codeEditor member with the _ui->codeEditor like other widgets.
  • Changed and named the main layout of the Timeline editor widget to be a horizontal layout.
  • Gave the root main layout some default spacing of 4 so everything isn't up against the edges of the editor subwindow.
  • Removed a bunch of unused includes.

@RobertBColton RobertBColton merged commit 4414a49 into master Aug 29, 2020
@RobertBColton RobertBColton deleted the timeline-codeeditor-embed branch August 29, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants