Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Editor Layout #169

Merged
merged 9 commits into from
Sep 3, 2020
Merged

Path Editor Layout #169

merged 9 commits into from
Sep 3, 2020

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Aug 29, 2020

Fixing up the path editor to not be so confusing and scattered around.

  • Removed the hard coded toolbar style that was manually setting the spacing. It was inconsistent because we aren't doing it for the other editors.
  • Removed the spinboxes because they are confusing since we aren't doing a master detail view like GM does. The user can just edit the values inside the table by double clicking. This also gives more vertical space to show more points.
  • Used default values everywhere the spinboxes were being referred to in code.
  • Gave unique names to several widgets in the form that didn't previously have any.
  • Added label mnemonics and buddies to several widgets.
  • Gave the points list buttons text and showed it so they don't look so bland and they can have the GM mnemonic.
  • Changed the insert icon from the pencil to the copy icon because it more accurately, while not perfectly, represents the insert behavior. Since the insert button actually behaved like duplicate in GM, this is actually more correct. Duplicate is also more useful than a plain insert button anyway.
  • Made the save button the default button.
  • Made the point preview widget stretch so that it looks correct in the form designer.
  • Removed the extra separator at the beginning of the toolbar. I'm not sure why it was there.
Master Pull Request
Master Path Editor Pull Request Path Editor

@RobertBColton RobertBColton merged commit 7a4ba6f into master Sep 3, 2020
@RobertBColton RobertBColton deleted the path-properties-layout branch September 3, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants