Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Handel duplicate cert #244

Open
muzammilrehman opened this issue Feb 5, 2024 · 2 comments
Open

[feature request]Handel duplicate cert #244

muzammilrehman opened this issue Feb 5, 2024 · 2 comments

Comments

@muzammilrehman
Copy link

With version 3.x.x, the server doesn't crash when Kubernetes secret has a duplicate certificate but it does not expose other certs' metrics. It would be good to either directly ignore the duplicate certs or give the option to the user via a flag to ignore these.

~ # curl http://172.20.72.13:9793/metrics
An error has occurred while serving metrics:

collected metric "x509_cert_error" { label:{name:"secret_key"  value:"pubkey"}  label:{name:"secret_name"  value:"certs-server"}  label:{name:"secret_namespace"  value:"xxx"}  xxx:{value:1}} was collected before with the same name and label values
@AnuragEkkati
Copy link

@muzammilrehman this should be bug if it is 100% reproducible

@carinadigital
Copy link

I've encountered the same problem. I would suggest that if a duplicate cert is found then it's simply ignored and an error printed to the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants