Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the EIP-1538 Implementation with EIP-2535, the Diamond Standard #27

Open
mudgen opened this issue Jul 19, 2020 · 1 comment
Open

Comments

@mudgen
Copy link

mudgen commented Jul 19, 2020

This implementation is using EIP-1538 for its upgrades. Specifically EIP-1538 is implemented in the contracts in the ProxyReceiver folder.

EIP-1538 has been abandoned and replaced by EIP-2535, the Diamond Standard.

EIP-2535, or the Diamond Standard, is an improvement over EIP-1538.

I suggest replacing the implementation of EIP-1538 in this repository with an implementation of EIP-2535. I suggest using the reference implementation of EIP-2535 to do this.

Some information about the Diamond Standard:

Here's a couple articles about EIP-2535:

Understanding Diamonds on Ethereum
Ethereum's Maximum Contract Size Limit is Solved with the Diamond Standard

One of the authors (Ronan Sandford) of ERC-1155 is currently building tooling for EIP-2535. Here is a link to his announcement: https://twitter.com/wighawag/status/1280992800545349644

I am the author of the Diamond Standard so if you have any questions or need help then let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@mudgen and others