Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[PLA-1446] Add volumes (#26)" #28

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Revert "[PLA-1446] Add volumes (#26)" #28

merged 1 commit into from
Nov 29, 2023

Conversation

leonardocustodio
Copy link
Member

This reverts commit b02d04a.

@leonardocustodio leonardocustodio self-assigned this Nov 29, 2023
@leonardocustodio leonardocustodio added the bug Something isn't working label Nov 29, 2023
@enjinabner
Copy link
Contributor

enjinabner commented Nov 29, 2023 •
edited
Loading

What's the reason for this revert?

@leonardocustodio
Copy link
Member Author

leonardocustodio commented Nov 29, 2023 •
edited
Loading

There are file permission issues. The containers can't read the environment files.
Not sure why it worked before, but since it happened now, needs better debugging/testing.

@leonardocustodio leonardocustodio merged commit 6c5c573 into master Nov 29, 2023
1 check failed
@leonardocustodio leonardocustodio deleted the revert-volumes branch November 29, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjinabner enjinabner enjinabner approved these changes

@v16Studios v16Studios Awaiting requested review from v16Studios v16Studios is a code owner

Assignees

@leonardocustodio leonardocustodio

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonardocustodio @enjinabner