Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove platform throttle config #45

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Remove platform throttle config #45

merged 1 commit into from
Jul 18, 2024

Conversation

enjinabner
Copy link
Contributor

@enjinabner enjinabner commented Jul 17, 2024 •
edited by github-actions bot
Loading

PR Type

configuration changes

Description

  • Removed ENJIN_PLATFORM_API_THROTTLE configuration from the .env file.

Changes walkthrough 📝

Relevant files
Configuration changes
.env
Remove `ENJIN_PLATFORM_API_THROTTLE` configuration             

configs/core/.env

  • Removed ENJIN_PLATFORM_API_THROTTLE configuration.
 +0/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@enjinabner enjinabner self-assigned this Jul 17, 2024
@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@github-actions GitHub Actions
Copy link

PR Code Suggestions ✨

No code suggestions found for PR.

leonardocustodio
leonardocustodio approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@leonardocustodio leonardocustodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented in the docs? We are not sure how the adopters will use their platform so they might run into an issue if this is disabled and they don't know about it.

If it is documented alredy feel free to merge.

@enjinabner
Copy link
Contributor Author

Is this documented in the docs? We are not sure how the adopters will use their platform so they might run into an issue if this is disabled and they don't know about it.

If it is documented alredy feel free to merge.

This is only applicable for multi-tenant package which is not public to adopters

@enjinabner enjinabner merged commit 26016c3 into master Jul 18, 2024
1 check passed
@enjinabner enjinabner deleted the PLA-1896 branch July 18, 2024 00:53
@leonardocustodio
Copy link
Member

Ahh now it makes sense 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardocustodio leonardocustodio leonardocustodio approved these changes

@v16Studios v16Studios Awaiting requested review from v16Studios v16Studios is a code owner

Assignees

@enjinabner enjinabner

Labels
configuration changes Review effort [1-5]: 1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enjinabner @leonardocustodio