From c37ed888d7e63bbb3e7646e6b4b1dcab1c227069 Mon Sep 17 00:00:00 2001
From: Ry Biesemeyer <ry.biesemeyer@elastic.co>
Date: Sun, 20 Jan 2019 14:48:31 +0000
Subject: [PATCH] add JRuby 9.2 and Java 11 to the ci mix

The `JAVA_OPTS` environment variable is used by JRuby to launch the JVM with
appropriate options; by adding specific `--add-opens` flags, we are able to
enable the specific reflective access that is necessary to run in Javas >= 9.

For ci, we set `JAVA_OPTS` with the contents of `JAVA_OPTS_FOR_SPECS` inside
the `before_script` in order to avoid invoking all jruby JVMs with the flags.
---
 .travis.yml | 7 +++++++
 README.md   | 2 ++
 2 files changed, 9 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 0c38d5e..90b63aa 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,6 +24,9 @@ before_install:
   - ruby -e "system('gem update --system') if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.3')"
   - gem install bundler --version '~> 1.17'
 
+before_script:
+  - 'export JAVA_OPTS="${JAVA_OPTS_FOR_SPECS}"'
+
 env:
   global:
   matrix:
@@ -36,6 +39,10 @@ matrix:
     - rvm: jruby-9.1.9.0
     - rvm: ruby-head
     - env: "CHILDPROCESS_POSIX_SPAWN=true"
+  include:
+  - rvm: jruby-9.2.5.0
+    jdk: openjdk11
+    env: "JAVA_OPTS_FOR_SPECS='--add-opens java.base/java.io=org.jruby.dist --add-opens java.base/sun.nio.ch=org.jruby.dist'"
   exclude:
     # Travis does not provide 1.9.3 on OSX
   - rvm: 1.9.3
diff --git a/README.md b/README.md
index 80454d8..44bddbc 100644
--- a/README.md
+++ b/README.md
@@ -173,6 +173,8 @@ ChildProcess.logger = logger
 ## Caveats
 
 * With JRuby on Unix, modifying `ENV["PATH"]` before using childprocess could lead to 'Command not found' errors, since JRuby is unable to modify the environment used for PATH searches in `java.lang.ProcessBuilder`. This can be avoided by setting `ChildProcess.posix_spawn = true`.
+* With JRuby on Java >= 9, the JVM may need to be configured to allow JRuby to access neccessary implementations; this can be done by adding `--add-opens java.base/java.io=org.jruby.dist` and `--add-opens java.base/sun.nio.ch=org.jruby.dist` to the `JAVA_OPTS` environment variable that is used by JRuby when launching the JVM.
+
 
 # Implementation