Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare service name from ctf.json with the one the checker declares (and abort gracefully) #143

Open
Trolldemorted opened this issue Apr 24, 2021 · 5 comments

Comments

@Trolldemorted
Copy link
Member

No description provided.

@ldruschk
Copy link
Member

In that case, can't we just take the name from the checker and remove it from the ctf.json?

@Trolldemorted
Copy link
Member Author

Then you don't check whether an entry actually matches with the intended checker

@Savallator
Copy link
Contributor

In my opinion this should just print a warning. Otherwise, it just makes testing harder (e.g. what about the case when a checker does not answer the query?

@ldruschk
Copy link
Member

Then you don't check whether an entry actually matches with the intended checker

Is the service name the best identifier for that? What about different cases, spaces or stuff like that?

@Trolldemorted
Copy link
Member Author

Is the service name the best identifier for that? What about different cases, spaces or stuff like that?

The service name should match to ensure matching logs in EnoELK, so I would like to know when it does not asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants