Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar record doesn't work for domains with unicode characters #50

Closed
scottweston opened this issue Nov 24, 2021 · 4 comments
Closed

avatar record doesn't work for domains with unicode characters #50

scottweston opened this issue Nov 24, 2021 · 4 comments

Comments

@scottweston
Copy link

getResolver() is returning null for domains containing unicode here:

var resolver = await this.defaultProvider.getResolver(uri);

This is resulting in domains with otherwise correctly set avatar text fields not working as intended.

e.g. https://metadata.ens.domains/mainnet/avatar/%F0%9F%91%91scott.eth

@scottweston scottweston changed the title avatar record doesn't work for domains with unicode charaters avatar record doesn't work for domains with unicode characters Nov 24, 2021
@lucashenning
Copy link

+1 - same issue with a unicode domain not resolving:

@stronk-dev
Copy link

I am experiencing this issue with one of my ENS domains:
https://metadata.ens.domains/mainnet/avatar/livepeer%F0%9F%9A%80%F0%9F%8C%91.eth/meta

Interestingly enough 1inch does show the icon, but uniswap, opensea and app.ens aren't able to load the image

@benpercifield
Copy link

i've set the avatar for ✨ben✨.eth 4 times now lol

  • doing a NFT didnt work bc I tried to set videos so thats a separate problem nbd
  • Reached out to support for help and was told I can do an IPFS hash in addition to NFTs
  • doing an IPFS hash didnt work
  • this is the IPFS hash i used: ipfs://QmU2qw9pti3cA95dva7cGyMFBY6ra98cGzFjuaYsqwSeKt

Thank you for making emoji names work! <3

@mdtanrikulu
Copy link
Member

after ethers been updated, I am seeing all of the names listed here are working.
only ✨ben✨.eth has an issue with the NFT, but it appears to be on the NFT contract side rather than metadata service.

I am getting call_exception when try to get metadata of the NFT from it's own contract;

image

using another NFT, or contacting with the team of current set NFT may help solving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants