-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avatar record doesn't work for domains with unicode characters #50
Comments
+1 - same issue with a unicode domain not resolving: |
I am experiencing this issue with one of my ENS domains: Interestingly enough 1inch does show the icon, but uniswap, opensea and app.ens aren't able to load the image |
i've set the avatar for ✨ben✨.eth 4 times now lol
Thank you for making emoji names work! <3 |
after ethers been updated, I am seeing all of the names listed here are working. I am getting call_exception when try to get metadata of the NFT from it's own contract; using another NFT, or contacting with the team of current set NFT may help solving. |
getResolver()
is returningnull
for domains containing unicode here:ens-metadata-service/src/avatar.ts
Line 258 in dd6a1b1
This is resulting in domains with otherwise correctly set
avatar
text fields not working as intended.e.g. https://metadata.ens.domains/mainnet/avatar/%F0%9F%91%91scott.eth
The text was updated successfully, but these errors were encountered: