Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDataViewWidget inheriting HasStrictTraits causes problems with super() #1067

Closed
Tracked by #968
corranwebster opened this issue Dec 22, 2021 · 1 comment
Closed
Tracked by #968

MDataViewWidget inheriting HasStrictTraits causes problems with super() #1067

corranwebster opened this issue Dec 22, 2021 · 1 comment
Labels
type: bug
Milestone
Release 7.4.0

Comments

@corranwebster
Copy link
Contributor

Since Widget and MWidget inherit from HasTraits, and MDataWidget is first in the MRO, we get HasStrictTraits second, which messes with super() calls to MWidget as HasStrictTraits doesn't have the right methods.

Fixes are either to consistently use HasTraits or HasStrictTraits, but HasStrictTraits is not backwards compatible, so we should drop use of that for now.
@corranwebster corranwebster added this to the Release 7.4.0 milestone Dec 22, 2021
@corranwebster corranwebster mentioned this issue Dec 22, 2021
Open
26 tasks
@corranwebster corranwebster mentioned this issue Dec 22, 2021
Merged
@corranwebster
Copy link
Contributor Author

Fixed by #1066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Release 7.4.0
Development

No branches or pull requests
1 participant
@corranwebster