Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons.zip and std.zip are changed after the test suite is run #776

Open
kitchoi opened this issue Oct 19, 2020 · 1 comment
Open

icons.zip and std.zip are changed after the test suite is run #776

kitchoi opened this issue Oct 19, 2020 · 1 comment
Labels
component: test suite Issues related to testing, test support, test interactions...

Comments

@kitchoi
Copy link
Contributor

kitchoi commented Oct 19, 2020

While developing, one often runs the test suite locally before pushing their changes. After running the test suites, these two files are reported to be changed by git:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   pyface/image/library/icons.zip
	modified:   pyface/image/library/std.zip

Then what often happens is that developers did not notice that and commit these changes as part of their PR. However these changes are orthogonal and had to be reverted (or otherwise every PR will be creating merge conflicting with other PRs). This has bitten at least 3 developers as far as I can tell.

See this comment: #769 (comment)

@kitchoi kitchoi added the component: test suite Issues related to testing, test support, test interactions... label Oct 19, 2020
@corranwebster
Copy link
Contributor

The fix for this is possibly to not commit the zip files, but instead have the contents of the zip files in the git repo and have the zip files be generated as part of the build process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: test suite Issues related to testing, test support, test interactions...
Projects
None yet
Development

No branches or pull requests

2 participants