Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some content of optional_dependencies to traits.testing.api #1236

Closed
kitchoi opened this issue Jul 8, 2020 · 6 comments
Closed

Add some content of optional_dependencies to traits.testing.api #1236

kitchoi opened this issue Jul 8, 2020 · 6 comments
Labels
component: test suite Issues related directly to the test suite

Comments

@kitchoi
Copy link
Contributor

kitchoi commented Jul 8, 2020

Pyface needed requires_numpy and numpy from traits.testing.optional_dependencies (see discussion). So this issue is for moving these objects (maybe along others too) to traits.testing.api so that pyface can import from it safely (related to #1213)

@rahulporuri rahulporuri added the component: test suite Issues related directly to the test suite label Jul 8, 2020
@mdickinson
Copy link
Member

I'd rather have Pyface re-implement than import from Traits here. The functionality has nothing particularly to do with Traits, and Traits is not the right place for common non-Trait-related utilities.

@rahulporuri
Copy link
Contributor

i think it's still useful to make optional_dependencies accessible from the api module.

@kitchoi
Copy link
Contributor Author

kitchoi commented Jul 8, 2020

For the record, I am in favour of pyface reimplementing those objects.

@mdickinson
Copy link
Member

mdickinson commented Jul 8, 2020

i think it's still useful to make optional_dependencies accessible from the api module.

I disagree. Everything we put in an api module is something we're guaranteeing to support. Traits already has a bunch of utilities that have nothing to do with Traits in particular; I don't want to add to those.

Utilities that are directly Traits-related are a different matter, of course.

@kitchoi
Copy link
Contributor Author

kitchoi commented Jul 8, 2020

I am happy for this issue to be closed as a wont-fix...

@kitchoi
Copy link
Contributor Author

kitchoi commented Jul 8, 2020

Closing... If anyone wants to advocate further for this, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: test suite Issues related directly to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants