Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support regex rewrites for paths during HTTP redirects #14348

Closed
esmet opened this issue Dec 9, 2020 · 1 comment · Fixed by #14351
Closed

Support regex rewrites for paths during HTTP redirects #14348

esmet opened this issue Dec 9, 2020 · 1 comment · Fixed by #14351
Labels
area/http enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@esmet
Copy link
Contributor

esmet commented Dec 9, 2020

Envoy supports regex rewrites for paths when proxying to upstream clusters using regex_rewrite on the RouteAction https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-routeaction

It should be possible to also rewrite the Location header returned for redirects using the same regex rewrite config by adding regex_rewrite to the RedirecAction here https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-redirectaction and implementing the behavior in RouteEntryImplBase::getPathRewreite.
@esmet esmet added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 9, 2020
@dio dio added area/http help wanted Needs help! and removed triage Issue requires triage labels Dec 9, 2020
@esmet esmet mentioned this issue Dec 9, 2020
Merged
@esmet
Copy link
Contributor Author

esmet commented Dec 12, 2020

@dio feel free to assign this one to me

@esmet esmet mentioned this issue Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/http enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

route: add regex_rewrite to redirect action esmet/envoy
2 participants
@dio @esmet