Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gperftools-based builds #17854

Closed
PKizzle opened this issue Aug 25, 2021 · 9 comments
Closed

Publish gperftools-based builds #17854

PKizzle opened this issue Aug 25, 2021 · 9 comments
Labels
area/perf enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@PKizzle
Copy link

PKizzle commented Aug 25, 2021

As discussed in #15235 devices with a page table size of 3 are not able to run builds based on Google's tcmalloc.
Changing the page table size to 4 requires a kernel rebuild. This is especially relevant for RaspberryPi owners.
Therfore until issues google/tcmalloc#82 or raspberrypi/linux#4375 are closed envoy versions >= 1.17 should also be published using gperftools' tcmalloc.

@PKizzle PKizzle added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Aug 25, 2021
@phlax phlax added area/perf and removed triage Issue requires triage labels Aug 26, 2021
@phlax
Copy link
Member

phlax commented Aug 26, 2021

cc @lizan

@mattklein123
Copy link
Member

I don't think we have the resources to do a separate build/image for this. I suppose we could make the contrib ARM image use the other malloc? I would need to see if it causes a full source rebuild or not.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 26, 2021
@PKizzle
Copy link
Author

PKizzle commented Sep 27, 2021

@mattklein123 were you able to test whether building the contrib arm image using gperftools’ tcmalloc works?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Sep 27, 2021
@mattklein123
Copy link
Member

@mattklein123 were you able to test whether building the contrib arm image using gperftools’ tcmalloc works?

I haven't tested. I'm pretty sure it will cause almost a complete rebuild but feel free to try it out.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 27, 2021
@PKizzle
Copy link
Author

PKizzle commented Nov 1, 2021

I compiled envoy using the envoy-proxy/envoy-build-ubuntu docker image by adding BAZEL_BUILD_EXTRA_OPTIONS="--define tcmalloc=gperftools" and rerunning the build without it. It seems like it is doing a full rebuild 🙁
Still an arm64 image with that tcmalloc option would be nice to have for all RaspberryPi owners

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/perf enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants