-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move Golang extension from contrib to standard #31685
Comments
This list looks great to me. The one thing I think you're missing is maintainer sponsorship - not sure if you've already gotten someone to sign on or if you want to cc the maintainers list and see who is game for sponsoring. |
Thank you for your kind words. We don’t have a maintainer sponsor yet. Would you be interested in sponsoring us? It would be an honor for us. 🙏 |
Unfortunately good as I think the extension is, I don't have the cycles to spin up context and do reviews. |
I think there may be huge of review work to move this extension. I can help in code quality but I am not familiar with the cgo, so we still need another maintainer who are familiar to or at least interest in that. |
I'd like to add an extra comment for the docs side, the lifecycle of all of the functions and golang features (like the unit function, vars, etc) should be documented to help people. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
@doujiang24 We're currently considering using this for production mission-critical services. Do you think the golang extension are in that stage? |
@Olshansk Yep, I think it's ready for production, we have using it in production over a year. The main risk comes from the stability of the API. |
Motivation
Make people use the standard version with confidence.
Some people have expressed concerns about the contrib version, i.e. the thread in enovy-go slack channel.
Status
The latest envoy 1.28.0 should be stable enough.
All knowned bug are fixed in envoy 1.28.0. And no new bugs reported since 1.28.0.
Nearly ~100 improvements, and ~5 bugfixes since first merged in contrib.
i.e. retired the
GODEBUG=cgocheck=0
env requirement.Test
Doc
There are some baisc doc about how to develop and build plugin, and examples for how to implement golang plugins.
Question
In addition to these TODOs, what else needs to address? Or, any other requirements?
cc @mattklein123 @alyssawilk @phlax @wbpcode Any advice & guidance? Thanks very much!
Maybe it could be done in the 1.31 release? if there are no big blocking issue.
The text was updated successfully, but these errors were encountered: