You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: linkstamp is currently used by the VersionInfo class to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:
linkstamp is not available for non-binary rules. Thus if the version_info_lib is compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robust linkstamp mechanism we use for binary rules.
The text was updated successfully, but these errors were encountered:
@junr03 it's sufficient for me to share, thanks. I think if we want action on the Bazel front though, it would be good to have a tracking issue in their GH.
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.
bazel: expand linkstamp beyond binary rules.
Description:
linkstamp
is currently used by theVersionInfo
class to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:linkstamp
is not available for non-binary rules. Thus if theversion_info_lib
is compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robustlinkstamp
mechanism we use for binary rules.The text was updated successfully, but these errors were encountered: