-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--allow-unknown-fields has no effect; unknown fields are rejected #7936
Comments
I think this is fixed by #7857 |
cc @htuch |
Great, thanks! Just a note -- it seems that while with the latest the flag is inverted, with an older version |
@howardjohn if it's working now, but inverted, I think this should be solved by #7857. Hope to merge this in the next day or so. |
@htuch it seems that with #7857 it is no longer inverted, but rather all flags This should be reproducible with Any ideas what is happening here? |
In 1.3 we are using allow-unknown-fields in istio 1.3 is that not working ? |
@mandarjog it appears to have been broken for a while |
@howardjohn I'll look into this later today. |
@howardjohn this works for me, see:
and
It's detecting the unknown field and warning (as expected for the dynamic config), but it accepts it still. |
@htuch thanks! I didn't realize it was just warning. Looks good now, I think this can be closed. Thanks for the fix |
Bug Template
Title: --allow-unknown-fields has no effect; unknown fields are rejected
Description:
When setting
--allow-unknown-fields
, unknown fields still seem to be rejectedWhen NOT setting
--allow-unknown-fields
, unknown fields seem to be acceptedRepro steps:
Download bootstrap.yaml and lds.yaml:
repro.zip
Run
docker run -v ${PWD}:/tmp/envoy envoyproxy/envoy-dev:882a30677619856446f7e1b9d28c6ab319b21d1b -c /tmp/envoy/bootstrap.yaml
Output:
Run
docker run -v ${PWD}:/tmp/envoy envoyproxy/envoy-dev:882a30677619856446f7e1b9d28c6ab319b21d1b -c /tmp/envoy/bootstrap.yaml --allow-unknown-fields
Output:
The text was updated successfully, but these errors were encountered: