Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacePrefixMatch broken in main #4331

Open
zetaab opened this issue Sep 25, 2024 · 1 comment
Open

replacePrefixMatch broken in main #4331

zetaab opened this issue Sep 25, 2024 · 1 comment
Labels

Comments

@zetaab
Copy link
Contributor

zetaab commented Sep 25, 2024

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

with envoy gateway 1.1 I was using following spec

    - type: URLRewrite
      urlRewrite:
        path:
          type: ReplacePrefixMatch
          replacePrefixMatch: /docs/

So my goal is to add /docs/ prefix to all url paths. So it will be modified like /docs/<originalpath>.

With latest main the request path was modified only /docs<originalpath> (NOTE! missing last slash)

However, with latest main it will not add the ending slash anymore. I was forced to use

    - type: URLRewrite
      urlRewrite:
        path:
          type: ReplacePrefixMatch
          replacePrefixMatch: /docs//

to get same behaviour working.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

eg 1.1 (envoy 1.31) and main (with envoy distroless-devel)

Logs:

Include the access logs and the Envoy logs.

@zetaab zetaab added the triage label Sep 25, 2024
@arkodg
Copy link
Contributor

arkodg commented Sep 25, 2024

this was supposed to be fixed with #3990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants