-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate generating Rate Limit Config gRPC pb files from source proto #646
Comments
@renuka-fernando something similar to https://github.com/envoyproxy/envoy/blob/b03b18122f439b3bb53801c681aac663907fdcf0/.azure-pipelines/pipelines.yml#L276 might be required in envoyproxy/ratelimit |
Thanks @arkodg. |
apologies i missed this before - just flagging that the linked CI job is a bit of an anti pattern - it causes frequent races in CI where multiple jobs are trying to update at the same time ive thought about it quite a bit but havent thought of a better way to do this so far |
What is if we move the rls_conf.proto to envoyproxy/envoy repo? |
sounds sensible to me but it needs api-sheps to look - perhaps raise a Pr and see what they say |
just clarifying that the problem (iirc) more occurs with filter example as it is pushed more freqently i think - but the pattern is the same |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
@phlax Is there anything I can help with? What are the options to resolve the issue? |
My 2c is that generated protobuf bindings for rate limit should like in the ratelimit repository so they can be tagged and release-managed along with the ratelimit server itself. If you do that, then there's no need for complicated CI workflows. |
Thanks for sharing your ideas. Currently, does rate limit repo have pipeline in place to generate any protobuf bindings? |
im not familiar with the ratelimit repo - but checking it seems that it has some build/test ci ( |
AFAIK, those are for GitHub actions used for PR check validations. It is really great if it is possible to automate generating pb files for Rate Limit Config proto files. cc @alecholmez |
4 decisions needed here
|
@phlax I have a sketch here: https://github.com/envoyproxy/ratelimit/compare/main...dio:ratelimit:generated/sync?expand=1#diff-9378a8b24aa534a459299b517298bbae5c3865058af860aba203ff6e069d5123 The process is roughly as follows:
Notes:
|
I don't understand why we want a complicated CI mechanism to generate protobufs here. We could just generate and commit them to the |
Re-opening due to the discussion. |
True that. I agree that we can "just" generate it inside the ratelimit repo (check-in the generated *.pb.go) and don't need to sync it here (use it as a module instead). |
Some points, AFAIR, the reasons to have Ratelimit pb files in the go-control-plane.
To remove the cyclic dependencies we have to put the Ratelimit pb files in go-control-plane. So ratelimit is not a dependency of go-control-plane but go-control-plane is a dependency of ratelimit. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
Description
It is better to have an automated way to generate pb files for Rate Limit Config as discussed here #598 (comment).
The source files of the config reside in https://github.com/envoyproxy/ratelimit/blob/main/api/ratelimit/config/ratelimit/v3/rls_conf.proto.
Generated pb files https://github.com/envoyproxy/go-control-plane/tree/main/ratelimit
Related Issue
#595
The text was updated successfully, but these errors were encountered: