Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request.useragent column in database nullable #881

Open
FastLizard4 opened this issue Nov 13, 2023 · 2 comments
Open

Make request.useragent column in database nullable #881

FastLizard4 opened this issue Nov 13, 2023 · 2 comments
Labels
good first issue This task is suitable for developers new to the project schema changes This task requires database schema changes

Comments

@FastLizard4
Copy link
Member

Currently, the request.useragent column in the database is defined as TEXT NOT NULL, which means that any requests we receive where we don't receive a User-Agent HTTP header will cause an exception and fail. Currently we only see this with requests that appear to be fuzzed for automated scanning or similar, but it's still not an ideal behavior.

To fix, we should make the request.useragent column nullable.

@FastLizard4 FastLizard4 added the schema changes This task requires database schema changes label Nov 13, 2023
@FastLizard4
Copy link
Member Author

Note that there's currently a handful of open PRs that make database changes (#852, #854, and #856) so it's probably best for those to get merged in before working on this (or, alternatively, base any change for this issue on the branch for #856).

@stwalkerster
Copy link
Member

This is a good first issue This task is suitable for developers new to the project candidate, as the change required should be very similar to #713

I won't tag it as such yet due to the other stuff pending.

@stwalkerster stwalkerster added the good first issue This task is suitable for developers new to the project label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This task is suitable for developers new to the project schema changes This task requires database schema changes
Projects
None yet
Development

No branches or pull requests

2 participants