Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot deserialize input JSON if using Clean Up functionality on structure containing R-Groups #1391

Closed
akolyakov42 opened this issue Apr 1, 2022 · 6 comments
Assignees
Labels
bug external Issue depends on external services such as Indigo service
Milestone

Comments

@akolyakov42
Copy link

akolyakov42 commented Apr 1, 2022

Steps to Reproduce

  1. Launch Ketcher
  2. Add structure containing R-Groups on canvas
  3. Clean Up canvas using button in Upper Toolbar

Expected behavior
Canvas Cleaned Up without any troubles

Actual behavior
'Error: Cannot deserialize input JSON.' error message appeared

User agent
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7)
AppleWebKit/537.36 (KHTML, like Gecko)
Chrome/99.0.4844.84
Safari/537.36

Ketcher version
v2.4.2-150-g311ed61a

Additional context
Reproduced in Standalone and Remote modes

@akolyakov42 akolyakov42 added the bug label Apr 1, 2022
@akolyakov42 akolyakov42 added the external Issue depends on external services such as Indigo service label Apr 1, 2022
@akolyakov42
Copy link
Author

akolyakov42 commented Apr 1, 2022

Attached issue in Indigo repository
epam/Indigo#699

@AndreiMazol AndreiMazol added this to the Release 2.5.0 milestone Apr 5, 2022
@fedorseliankin fedorseliankin self-assigned this Apr 6, 2022
@AndreiMazol
Copy link
Contributor

There is no workaround on client side, the issue should be fixed on BE ('location' property is lost after 'clean up' function execution). Moved to milestone 'Release 2.6'

@fedorseliankin
Copy link
Contributor

fedorseliankin commented Apr 11, 2022

When calling the CleanUp function, we send such data
"mol1": { "type": "molecule" "atoms": [ { "type" : "rg-label", "location": [1.3, 6.9250000001, 0], "$refs": ["rg-3"] } ] }
, while we receive the following as a response
"mol1": { "type": "molecule" "atoms": [ { "type" : "rg-label", "$refs": ["rg-3"] } ] }
, that is, there is no "location" field

@fedorseliankin
Copy link
Contributor

Verified in Release 2.5

@fedorseliankin
Copy link
Contributor

Checked in build 227

@fedorseliankin
Copy link
Contributor

Regression re-check, in build 2.5 - OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external Issue depends on external services such as Indigo service
Projects
None yet
Development

No branches or pull requests

4 participants